D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip

Wed Nov 8 11:30:15 UTC 2017

apol added a comment.

  LGTM. I assume the hover information stays the same?

INLINE COMMENTS

> CMakeLists.txt:48
>  
> +# if(KF5TextEditor_VERSION VERSION_GREATER 5.40.0)
> +    add_definitions(-DUSE_ANNOTATIONITEMDELEGATE)

I wouldn't compile it conditionally. Let's just bump the frameworks dependency once this is in...

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8709

To: kossebau
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171108/4bd96815/attachment.html>