D8688: Create annotation color from revision hash, not RNG number
Sven Brauch
noreply at phabricator.kde.org
Tue Nov 7 00:10:21 UTC 2017
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
INLINE COMMENTS
> vcsrevision.cpp:179
> + break;
> + case VcsRevision::Special:
> + switch (revisionValue.value<KDevelop::VcsRevision::RevisionSpecialType>()) {
can you simply return qHash<int>(revisionValue.value())?
REPOSITORY
R32 KDevelop
BRANCH
reproducableannotationcolor
REVISION DETAIL
https://phabricator.kde.org/D8688
To: kossebau, #kdevelop, brauch
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171107/5be367a5/attachment.html>
More information about the KDevelop-devel
mailing list