D8688: Create annotation color from revision hash, not RNG number

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Nov 7 00:08:19 UTC 2017


kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Generate the same background colors for annotations on every invocation of the
  annotation bar, for consistent display.
  
  Also generate the brush objects per revision only on-demand, no need to
  pregenerate all of them, as often the user only looks at the annotations for
  a smaller range.
  
  Also fix the hash algorithm for VcsRevision class to generate proper hash
  values for all types. Before it would have generated a value of 0 for any
  string-based revision values, like e.g. used by the git vcs plugin.

REPOSITORY
  R32 KDevelop

BRANCH
  reproducableannotationcolor

REVISION DETAIL
  https://phabricator.kde.org/D8688

AFFECTED FILES
  kdevplatform/vcs/models/vcsannotationmodel.cpp
  kdevplatform/vcs/vcsrevision.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171107/d2aa7ff7/attachment.html>


More information about the KDevelop-devel mailing list