D8654: Don't ask for compiler-specific includes in QmlJS

Aaron Puchert noreply at phabricator.kde.org
Sat Nov 4 18:38:59 UTC 2017


aaronpuchert created this revision.
aaronpuchert added a reviewer: KDevelop.

REVISION SUMMARY
  We can't provide these, since there is no QmlJS compiler.
  
  The entire design is a bit problematic, because the QmlJS plugin asks
  the DefinesAndIncludesManager for include directories, but that manager
  is somehow tied to the idea of using the configured compiler to provide
  additional includes and defines. However, the configured compiler is
  obviously only used for C/C++ and similar languages, not QmlJS.

REPOSITORY
  R32 KDevelop

BRANCH
  qmljs-fix

REVISION DETAIL
  https://phabricator.kde.org/D8654

AFFECTED FILES
  plugins/custom-definesandincludes/definesandincludesmanager.cpp
  plugins/custom-definesandincludes/definesandincludesmanager.h
  plugins/custom-definesandincludes/idefinesandincludesmanager.h
  plugins/qmljs/qmljsparsejob.cpp

To: aaronpuchert, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171104/9e6a6bf0/attachment.html>


More information about the KDevelop-devel mailing list