<table><tr><td style="">aaronpuchert created this revision.<br />aaronpuchert added a reviewer: KDevelop.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8654" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We can't provide these, since there is no QmlJS compiler.</p>

<p>The entire design is a bit problematic, because the QmlJS plugin asks<br />
the DefinesAndIncludesManager for include directories, but that manager<br />
is somehow tied to the idea of using the configured compiler to provide<br />
additional includes and defines. However, the configured compiler is<br />
obviously only used for C/C++ and similar languages, not QmlJS.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>qmljs-fix</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8654" rel="noreferrer">https://phabricator.kde.org/D8654</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/custom-definesandincludes/definesandincludesmanager.cpp<br />
plugins/custom-definesandincludes/definesandincludesmanager.h<br />
plugins/custom-definesandincludes/idefinesandincludesmanager.h<br />
plugins/qmljs/qmljsparsejob.cpp</div></div></div><br /><div><strong>To: </strong>aaronpuchert, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>