D8579: KDevelop: project filter support in the abstractfilemanagerplugin import benchmark

René J.V. Bertin noreply at phabricator.kde.org
Thu Nov 2 17:33:01 UTC 2017

rjvbb added a comment.

  > hm, I'd prefer using the actual controller setup as that is less brittle. I.e. if anything changes in the future, this will silently break, most probably.
  I understand. I'll see if calling ProjectController::addProject() has any side-effects (crashes as I've had before, activation of other plugins that shouldn't be activated etc) but that's a protected method. We'd have to make AbstractFileManagerPluginImportBenchmark a friend class of ProjectController too, or make the method public.
  I'd say that ProjectController::openProject() is really inappropriate here.

  R32 KDevelop


To: rjvbb, #kdevelop
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171102/034120d2/attachment.html>

More information about the KDevelop-devel mailing list