D8588: Make VCS data container classes implicitly shared
noreply at phabricator.kde.org
Thu Nov 2 16:17:56 UTC 2017
mwolff added a comment.
Big change is big. Why did you bother doing it? Do you have performance measurements indicating that this is a bottleneck? If so, do you want to save memory or do you want to make things faster? Would it maybe be enough to add move semantics?
I'm not in principle opposed to this patch, considering the work is done. Though for the future, please try to trim down the verbosity of the tests. They are really much too big. I.e. testing the permutations of changing A and then changing B is pretty pointless imo.
To: kossebau, #kdevelop
Cc: mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel