D8579: KDevelop: project filter support in the abstractfilemanagerplugin import benchmark
noreply at phabricator.kde.org
Thu Nov 2 16:06:52 UTC 2017
mwolff added a comment.
In https://phabricator.kde.org/D8579#163574, @rjvbb wrote:
> > I once again fail to understand you. What is a "properly set up filter" vs. what you are measuring here? Both should do the same thing now, no? I.e. open the project and load the configuration that contains custom filters to exclude e.g. the build dir.
> > > > Also, how would reordering default filters change anything?
> Hmm, you mean it doesn't really matter if you first check a directory called "build" against all "*.a", "*.o" and whatever uninteresting files that directory might contain before coming across the rule that excludes the entire directory, because either way you won't be scanning it?
Huh?! The files in the dir have nothing to do with the folder. Importing a project works like this: We list the contents recursively. If a folder is filtered out, we don't recurse into it. Also, we won't run file rules like `*.a` against a directory anyways. So I think you simply don't have a clue of how filtering is operating.
> Still, there should be some effect of rule order if the filter stops processing once a rule is triggered; for instance, why waste time checking all those *.o files against patterns that should occur much less often?
Maybe they occur less often for you. I never open folders that contain any `*.o`, since I always build out-of-source. So clearly haggling over order is a waste of time.
To: rjvbb, #kdevelop
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel