D8579: KDevelop: project filter support in the abstractfilemanagerplugin import benchmark

[René J.V. Bertin]

rjvbb marked 2 inline comments as done.
rjvbb added a comment.


  >   I once again fail to understand you. What is a "properly set up filter" vs. what you are measuring here? Both should do the same thing now, no? I.e. open the project and load the configuration that contains custom filters to exclude e.g. the build dir.
  >   >   >   Also, how would reordering default filters change anything? 
  
  Hmm, you mean it doesn't really matter if you first check a directory called "build" against all "*.a", "*.o" and whatever uninteresting files that directory might contain before coming across the rule that excludes the entire directory, because either way you won't be scanning it?
  
  Still, there should be some effect of rule order if the filter stops processing once a rule is triggered; for instance, why waste time checking all those *.o files against patterns that should occur much less often?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D8579

To: rjvbb, #kdevelop
Cc: mwolff, kdevelop-devel, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171102/258eedcd/attachment.html>