D5122: Allow users to install via a custom root installation command
noreply at phabricator.kde.org
Sun May 7 13:11:30 UTC 2017
zhigalin added a comment.
In https://phabricator.kde.org/D5122#107493, @kossebau wrote:
> In https://phabricator.kde.org/D5122#107479, @zhigalin wrote:
> > - When you edit an UI file, make sure not to forget to increase it's version
> This is a valid comment for kxmlgui rc files, but not for Qt ui files :) The version attribute of the `<ui>` rather specifies the version of the schema used, not of the content.
Too many kinds of ui files for one head, sorry:)
> Not sure what the effects of `<ui version="4.1">` are, at least for consistency I would propose the change it back to what it was before
No effects, but I reverted it for consistency
> kossebau wrote in makeconfig.ui:122
> This string does not match the handling in `switch(suCommandNum)` for value 2, or?
sudo just doesn't work as we don't have an interactive terminal here, so I removed it
However, if a user has previously selected sudo, it will be kept as transition code in `makejob.cpp` still works
To: geetamc, kfunk, zhigalin
Cc: kossebau, zhigalin, ltoscano, ematirov, kfunk, brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel