D5122: Allow users to install via a custom root installation command

[Alexander Zhigalin]

zhigalin accepted this revision.
zhigalin added a comment.


  Hello and thanks for your effort.
  Just a few considerations:
  
  - When you edit an UI file, make sure not to forget to increase it's version
  - You also forgot to bind `kcfg_suCommand.enabled(bool)` to `kcfg_installAsRoot.toggled(bool)`
  - You must use QStringLiteral, not just plain strings
  - Try placing less newlines around

INLINE COMMENTS

> makejob.cpp:186
> +        {
> +            QString suCommandstr;
> +            switch(suCommandNum)

Unused!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5122

To: geetamc, kfunk, zhigalin
Cc: zhigalin, ltoscano, ematirov, kfunk, brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170507/0a1f870c/attachment.html>