Review Request 126156: WIP: Allow using QTextBrowser for documentation instead of QtWebKit

[René J.V. Bertin]

> On May 6, 2017, 2:12 p.m., Eike Hein wrote:
> > This needs rebasing again after the buildsystem/webengine changes ... please save my sanity :(
> 
> René J.V. Bertin wrote:
>     > webengine changes
>     
>     ? This is about using QTextBrowser instead of WebKit, so where does WebEngine come in? (I thought there was some agreement *not* to let KDevelop depend on that behemoth?!)
> 
> Eike Hein wrote:
>     Basically build system stuff in kdevplatform was shuffled around when WebEngine support was added. It can use both WebEngine and WebKit now, but I don't want to build either, so ...

Yikes, yes. WebKit is one thing (I actually use it), WebEngine with its helper process(es) another... I have it installed so I hope it's not going to invite itself in my build once support for it appears in the 5.1 branch or I go back to using the master branch.

Is either actually required for the documentation popup windows? 

In fact, my suggestion here would be:
- use QTextBrowser (or some derivative) in KDevelop
- move the help/documentation components that could benefit from more capable HTML rendering to a standalone application (or a KPart that can either be loaded in KDevelop or in some dedicated shell application).

I have a hunch this would also reduce KDevelop's memory footprint if you use the documentation toolview(s)/plugin(s). And on Mac it could help prevent filedescriptor depletion when you have lots of Qt compressed help files.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126156/#review103192
-----------------------------------------------------------


On Jan. 10, 2017, 2:41 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126156/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 2:41 p.m.)
> 
> 
> Review request for KDevelop and René J.V. Bertin.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Allow using QTextBrowser instead of QtWebKit
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 554469fa29df1f3d2c7dd7896ca695377fafd202 
>   KDevPlatformConfig.cmake.in 73664ebd910c4c7e3acc41bdc048b0dc6141777e 
>   documentation/CMakeLists.txt ff57e258ab5c62ce737c4013005247d585e87b61 
>   documentation/config-documentation.h.cmake PRE-CREATION 
>   documentation/standarddocumentationview.h 3f429752032be6fa2b0b49fb3094f7bf31a28367 
>   documentation/standarddocumentationview.cpp a192e6fd9f0f92112a9b32ca2b9e2dc2f68063aa 
> 
> Diff: https://git.reviewboard.kde.org/r/126156/diff/
> 
> 
> Testing
> -------
> 
> compiles on my system which no longer has QtWebKit
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170506/ec4985f3/attachment-0001.html>