D5709: Implicitly shared class template: improve method declarations
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu May 4 13:48:58 UTC 2017
kossebau added a comment.
In https://phabricator.kde.org/D5709#106903, @mwolff wrote:
> http://doc.qt.io/qt-5/qshareddatapointer.html -> your change looks sane for *explicitly* shared data members, but not for implicit ones which will call detach in non-const `operator->()` automatically
> this also means that your setter will always detach, the equality check is really not needed and just code noise.
Eek, was not aware of that automatic detach for non-const methods. Will have to check some code of mine then :) Though first update of this patch...
To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel