D5709: Implicitly shared class template: improve method declarations

Milian Wolff noreply at phabricator.kde.org
Thu May 4 13:39:58 UTC 2017

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.

  http://doc.qt.io/qt-5/qshareddatapointer.html -> your change looks sane for *explicitly* shared data members, but not for implicit ones which will call detach in non-const `operator->()` automatically
  this also means that your setter will always detach, the equality check is really not needed and just code noise.

  R32 KDevelop


To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170504/3d7a5f5a/attachment.html>

More information about the KDevelop-devel mailing list