D5701: Do not extract all template preview images, load from archives on demand
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Thu May 4 10:23:50 UTC 2017
apol added inline comments.
INLINE COMMENTS
> templatesmodel.h:61
> DescriptionFileRole = Qt::UserRole + 1, ///< Template description file name
> - IconNameRole = Qt::UserRole + 2, ///< Template icon name
> + IconRole = Qt::UserRole + 2, ///< Template preview icon, returns a TemplatePreviewIcon
> CommentRole = Qt::UserRole + 3, ///< Template comment
Can we change the name entirely then?
It's not an icon after all.
> projectselectionpage.cpp:26
> #include <interfaces/iprojectcontroller.h>
> +#include "language/codegen/templatepreviewicon.h"
>
use angle brackets for the include
REPOSITORY
R33 KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D5701
To: kossebau, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170504/4e282ebd/attachment.html>
More information about the KDevelop-devel
mailing list