D5701: Do not extract all template preview images, load from archives on demand

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed May 3 18:51:09 UTC 2017


kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Saves disk space, IO and avoids garbage preview files due to no
  existing garbage collector.
  Ideally description files would also not be extracted,
  but KDesktopFile code sadly does not work against QIODevice.

TEST PLAN
  Previews work as before in the app wizard.
  No direct idea for a unit test, unless extending API
  of TemplatePreviewIcon just for that need.

REPOSITORY
  R33 KDevPlatform

BRANCH
  dontExtractTemplatePreviewFiles

REVISION DETAIL
  https://phabricator.kde.org/D5701

AFFECTED FILES
  language/CMakeLists.txt
  language/codegen/templatepreviewicon.cpp
  language/codegen/templatepreviewicon.h
  language/codegen/templatesmodel.cpp
  language/codegen/templatesmodel.h
  language/codegen/tests/test_templatesmodel.cpp
  plugins/appwizard/projectselectionpage.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170503/1a622496/attachment.html>


More information about the KDevelop-devel mailing list