D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command

[Mikhail Ivchenko]

ematirov added inline comments.

INLINE COMMENTS

> makejob.cpp:180
>      {
> -        int suCommand = builderGroup.readEntry( "Su Command", 0 );
> +        QString suCommand = builderGroup.readEntry( "Su Command", QString() );
>          QStringList arguments;

I wonder if that change will drop previous user selection, won't it? If so, maybe it's better to workaround that somehow.
Thus, in that scenario correct command should be chosen:

1. I use previous version of KDevelop.
2. I set su command to "kdesu".
3. I update KDevelop to version after your patch.
4. I expect that su command is still "kdesu".

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5122

To: geetamc, kfunk
Cc: ematirov, kfunk, brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170330/cb802c73/attachment.html>