D3040: Allow scaling documentation view (BUG 285162)

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  remove the moc, then feel free to push

INLINE COMMENTS

> igorkushnir wrote in CMakeLists.txt:7
> It's related. You have already written this comment, I've replied that I had changed `StandardDocumentationView` ABI, then you have agreed to leave this change in.

sorry :-/

> igorkushnir wrote in zoomcontroller.h:112
> This is a `ZoomController` class. It has a zoom factor, which is referred to as simply "factor" in member function names. It's obvious what factor it is as ZoomController shouldn't have any other factors. Do you want me to rename all 3 members: `factor()`, `setFactor()` and `factorChanged()`? What about `d->m_factor` and other variables in zoomcontroller.cpp?

leave it as is then, you are right - doesn't make much of a difference

REPOSITORY
  R33 KDevPlatform

BRANCH
  documentation-zoom-new-trimmed

REVISION DETAIL
  https://phabricator.kde.org/D3040

To: igorkushnir, #kdevelop, mwolff
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170322/2a3ff23d/attachment.html>