D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> makeconfig.ui:124
> +      <property name="text">
> +       <string>custom command</string>
> +      </property>

Casing: `Custom Command`

> makejob.cpp:195
> +                    return QStringList() << customCommand;
> +                else return QStringList() << "kdesu" << "-t"; 
> +            }

The else branch is not needed, let it fall-through.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5122

To: geetamc, kfunk
Cc: kfunk, brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170321/e5b55d22/attachment-0001.html>