D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command

[Sven Brauch]

brauch added a comment.


  Can you make the line edit disabled when something else than "custom command" is selected?
  Otherwise, LGTM, thanks for the patch!

INLINE COMMENTS

> makeconfig.ui:285
> +     <property name="text">
> +      <string>Custom root installation command</string>
> +     </property>

should have a : at the end

> makejob.cpp:195
> +                    return QStringList() << customCommand;
> +                else return QStringList() << "kdesu" << "-t"; 
> +            }

you can use {"kdesu", "-t"} these days, and {customCommand} in the previous line, but not an issue

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5122

To: geetamc
Cc: brauch, kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170321/fd694ccb/attachment.html>