D5071: Remove unused/unneeded includes & forward declarations

Thu Mar 16 17:45:14 UTC 2017

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Some people play Sudoku on the train, others play
  Gredelbuil (grep, remove, build), i.e. manually cleaning up
  includes and forward declarations which are not needed

  Done by primitive grepping for Q/K* class names and

  - removing any includes whose class does not have instances by a quick look in implementations in the same file
  - using forward declarations instead of includes for classes whe possible, unless a template class (because the latter is quite verbose as forward declarations, the include nicer to read)
  - removing any forward declarations which are not used in the same file

  (one day a bot/script will steal my game and beat me, o tempores)

  WRT effects on dependent code, at least kdevelop will need one or
  two adaptions due to changed include visibility. That is done as
  part of a similar clean-up patch, which will be either directly
  pushed or also passed through review, as you prefer.

REPOSITORY
  R33 KDevPlatform

BRANCH
  includeSpringCleaning

REVISION DETAIL
  https://phabricator.kde.org/D5071

AFFECTED FILES
  debugger/breakpoint/breakpointmodel.cpp
  debugger/breakpoint/breakpointwidget.cpp
  debugger/breakpoint/breakpointwidget.h
  debugger/framestack/framestackmodel.h
  debugger/framestack/framestackwidget.cpp
  debugger/interfaces/ibreakpointcontroller.h
  debugger/interfaces/idebugsession.cpp
  debugger/interfaces/idebugsession.h
  debugger/interfaces/ivariablecontroller.h
  debugger/util/pathmappings.cpp
  debugger/util/treeitem.cpp
  debugger/util/treeitem.h
  debugger/util/treemodel.cpp
  debugger/variable/variablecollection.cpp
  debugger/variable/variablecollection.h
  debugger/variable/variablesortmodel.h
  debugger/variable/variabletooltip.cpp
  debugger/variable/variabletooltip.h
  debugger/variable/variablewidget.cpp
  debugger/variable/variablewidget.h
  documentation/documentationview.cpp
  documentation/documentationview.h
  interfaces/configpage.cpp
  interfaces/configpage.h
  interfaces/context.cpp
  interfaces/context.h
  interfaces/contextmenuextension.h
  interfaces/iassistant.cpp
  interfaces/iassistant.h
  interfaces/ibuddydocumentfinder.h
  interfaces/icompletionsettings.cpp
  interfaces/icore.h
  interfaces/idocumentation.cpp
  interfaces/idocumentationprovider.h
  interfaces/idocumentationproviderprovider.h
  interfaces/ipartcontroller.cpp
  interfaces/ipartcontroller.h
  interfaces/iplugin.h
  interfaces/iplugincontroller.h
  interfaces/iproblem.h
  interfaces/iproject.cpp
  interfaces/iproject.h
  interfaces/iprojectcontroller.h
  interfaces/iprojectprovider.h
  interfaces/iruncontroller.h
  interfaces/isourceformatter.cpp
  interfaces/isourceformatter.h
  interfaces/isourceformattercontroller.h
  interfaces/itestcontroller.h
  interfaces/itestsuite.h
  interfaces/iuicontroller.h
  interfaces/launchconfigurationtype.h
  language/assistant/staticassistantsmanager.cpp
  language/assistant/staticassistantsmanager.h
  language/backgroundparser/backgroundparser.h
  language/backgroundparser/documentchangetracker.cpp
  language/backgroundparser/parsejob.cpp
  language/backgroundparser/tests/testlanguagesupport.cpp
  language/checks/controlflowgraph.h
  language/classmodel/classmodelnode.h
  language/codecompletion/codecompletion.h
  language/codecompletion/codecompletionmodel.cpp
  language/codecompletion/codecompletionmodel.h
  language/codecompletion/codecompletiontesthelper.h
  language/codecompletion/codecompletionworker.h
  language/codegen/archivetemplateloader.cpp
  language/codegen/codegenerator.cpp
  language/codegen/templateengine.cpp
  language/codegen/tests/test_templateclassgenerator.h
  language/codegen/tests/test_templaterenderer.h
  language/codegen/tests/test_templatesmodel.cpp
  language/codegen/tests/test_templatesmodel.h
  language/duchain/abstractfunctiondeclaration.h
  language/duchain/appendedlist.h
  language/duchain/builders/abstractcontextbuilder.h
  language/duchain/codemodel.cpp
  language/duchain/declarationid.h
  language/duchain/definitions.cpp
  language/duchain/duchain.cpp
  language/duchain/ducontext.cpp
  language/duchain/dumpdotgraph.h
  language/duchain/identifier.h
  language/duchain/importers.cpp
  language/duchain/navigation/abstractincludenavigationcontext.cpp
  language/duchain/navigation/abstractnavigationcontext.cpp
  language/duchain/navigation/abstractnavigationwidget.cpp
  language/duchain/navigation/abstractnavigationwidget.h
  language/duchain/navigation/problemnavigationcontext.cpp
  language/duchain/navigation/useswidget.h
  language/duchain/parsingenvironment.h
  language/duchain/persistentsymboltable.cpp
  language/duchain/tests/bench_hashes.cpp
  language/duchain/tests/test_duchainshutdown.cpp
  language/duchain/topducontext.cpp
  language/duchain/topducontextdynamicdata.cpp
  language/duchain/topducontextdynamicdata.h
  language/duchain/types/abstracttype.h
  language/duchain/types/typerepository.cpp
  language/duchain/types/typesystem.h
  language/duchain/uses.cpp
  language/highlighting/codehighlighting.h
  language/interfaces/abbreviations.cpp
  language/interfaces/abbreviations.h
  language/interfaces/quickopenfilter.h
  language/util/navigationtooltip.cpp
  outputview/outputexecutejob.h
  outputview/outputfilteringstrategies.h
  outputview/outputjob.h
  outputview/outputmodel.cpp
  outputview/tests/test_filteringstrategy.h
  outputview/tests/testlinebuilderfunctions.h
  plugins/appwizard/appwizarddialog.cpp
  plugins/appwizard/projectselectionpage.cpp
  plugins/appwizard/projecttemplatesmodel.h
  plugins/appwizard/projectvcspage.h
  plugins/bazaar/bazaarplugin.cpp
  plugins/bazaar/bzrannotatejob.h
  plugins/bazaar/tests/test_bazaar.cpp
  plugins/bazaar/tests/test_bazaar.h
  plugins/codeutils/codeutilsplugin.cpp
  plugins/contextbrowser/browsemanager.h
  plugins/contextbrowser/contextbrowserview.cpp
  plugins/contextbrowser/contextbrowserview.h
  plugins/documentswitcher/documentswitcherplugin.h
  plugins/documentswitcher/documentswitchertreeview.cpp
  plugins/documentview/kdevdocumentviewdelegate.cpp
  plugins/documentview/kdevdocumentviewdelegate.h
  plugins/documentview/kdevdocumentviewplugin.cpp
  plugins/execute/executeplugin.h
  plugins/execute/nativeappjob.h
  plugins/executescript/executescriptplugin.h
  plugins/executescript/iexecutescriptplugin.h
  plugins/externalscript/externalscriptitem.h
  plugins/externalscript/externalscriptplugin.cpp
  plugins/externalscript/externalscriptplugin.h
  plugins/filemanager/filemanager.cpp
  plugins/filemanager/kdevfilemanagerplugin.cpp
  plugins/filemanager/kdevfilemanagerplugin.h
  plugins/filetemplates/templateoptionspage.cpp
  plugins/filetemplates/templatepreview.cpp
  plugins/filetemplates/templatepreviewtoolview.cpp
  plugins/filetemplates/templateselectionpage.h
  plugins/filetemplates/testcasespage.cpp
  plugins/filetemplates/tests/data/testgenerationtest/templates/test_qtestlib/class.h
  plugins/filetemplates/tests/expected/testname.h
  plugins/filetemplates/tests/test_generationtest.cpp
  plugins/filetemplates/tests/test_generationtest.h
  plugins/genericprojectmanager/genericmanager.cpp
  plugins/git/gitplugin.cpp
  plugins/git/gitplugin.h
  plugins/git/tests/test_git.cpp
  plugins/git/tests/test_git.h
  plugins/grepview/grepdialog.h
  plugins/grepview/grepoutputmodel.cpp
  plugins/grepview/grepoutputview.cpp
  plugins/grepview/greputil.h
  plugins/openwith/openwithplugin.cpp
  plugins/outlineview/outlineviewplugin.cpp
  plugins/outlineview/outlinewidget.cpp
  plugins/outlineview/outlinewidget.h
  plugins/patchreview/localpatchsource.cpp
  plugins/patchreview/patchreview.h
  plugins/perforce/perforceplugin.cpp
  plugins/perforce/perforceplugin.h
  plugins/perforce/test/test_perforce.cpp
  plugins/problemreporter/problemreporterplugin.cpp
  plugins/problemreporter/problemsview.h
  plugins/problemreporter/problemtreeview.cpp
  plugins/problemreporter/tests/test_problemsview.cpp
  plugins/projectfilter/projectfilter.cpp
  plugins/projectfilter/projectfilter.h
  plugins/projectfilter/projectfilterconfigpage.cpp
  plugins/projectfilter/projectfilterprovider.cpp
  plugins/projectmanagerview/projectbuildsetwidget.cpp
  plugins/projectmanagerview/projectbuildsetwidget.h
  plugins/projectmanagerview/projectmanagerview.cpp
  plugins/projectmanagerview/projectmanagerview.h
  plugins/projectmanagerview/projectmanagerviewplugin.h
  plugins/projectmanagerview/projecttreeview.cpp
  plugins/projectmanagerview/projecttreeview.h
  plugins/quickopen/actionsquickopenprovider.cpp
  plugins/quickopen/documentationquickopenprovider.cpp
  plugins/quickopen/duchainitemquickopen.cpp
  plugins/quickopen/expandingtree/expandingdelegate.cpp
  plugins/quickopen/expandingtree/expandingdelegate.h
  plugins/quickopen/expandingtree/expandingtree.cpp
  plugins/quickopen/expandingtree/expandingwidgetmodel.cpp
  plugins/quickopen/expandingtree/expandingwidgetmodel.h
  plugins/quickopen/projectfilequickopen.h
  plugins/quickopen/quickopenmodel.h
  plugins/quickopen/quickopenplugin.cpp
  plugins/quickopen/quickopenwidget.cpp
  plugins/quickopen/quickopenwidget.h
  plugins/standardoutputview/standardoutputview.h
  plugins/standardoutputview/standardoutputviewmetadata.cpp
  plugins/standardoutputview/tests/test_standardoutputview.cpp
  plugins/standardoutputview/toolviewdata.h
  plugins/subversion/kdevsvnplugin.h
  plugins/subversion/svnaddjob.h
  plugins/subversion/svncatjob.h
  plugins/subversion/svncatjob_p.h
  plugins/subversion/svncheckoutmetadatawidget.cpp
  plugins/subversion/svnclient.cpp
  plugins/subversion/svnclient.h
  plugins/subversion/svncommitjob.cpp
  plugins/subversion/svncommitjob.h
  plugins/subversion/svncommitjob_p.h
  plugins/subversion/svncopyjob.h
  plugins/subversion/svndiffjob.cpp
  plugins/subversion/svndiffjob.h
  plugins/subversion/svndiffjob_p.h
  plugins/subversion/svninfojob.h
  plugins/subversion/svninternaljobbase.cpp
  plugins/subversion/svninternaljobbase.h
  plugins/subversion/svnjobbase.cpp
  plugins/subversion/svnjobbase.h
  plugins/subversion/svnmovejob.h
  plugins/subversion/svnremovejob.h
  plugins/subversion/svnrevertjob.h
  plugins/subversion/svnssldialog.cpp
  plugins/subversion/svnssldialog.h
  plugins/subversion/svnstatusjob.cpp
  plugins/subversion/svnstatusjob_p.h
  plugins/subversion/svnupdatejob.cpp
  plugins/subversion/svnupdatejob.h
  plugins/subversion/tests/svnimport.cpp
  plugins/subversion/tests/svnrecursiveadd.cpp
  plugins/switchtobuddy/switchtobuddyplugin.cpp
  plugins/testview/testview.cpp
  plugins/testview/testviewplugin.cpp
  plugins/vcschangesview/vcschangesviewplugin.h
  plugins/welcomepage/uihelper.cpp
  plugins/welcomepage/uihelper.h
  plugins/welcomepage/welcomepageview.cpp
  project/abstractfilemanagerplugin.cpp
  project/builderjob.h
  project/helper.cpp
  project/interfaces/iprojectbuilder.h
  project/interfaces/iprojectfilemanager.h
  project/interfaces/iprojectfilter.h
  project/projectbuildsetmodel.h
  project/projectconfigpage.h
  project/projectmodel.h
  project/projectproxymodel.h
  project/tests/projectmodelperformancetest.cpp
  project/tests/test_projectmodel.cpp
  serialization/abstractitemrepository.h
  serialization/itemrepositoryregistry.h
  serialization/tests/test_itemrepository.cpp
  serialization/tests/test_itemrepositoryregistry_automatic.cpp
  (123 more files...)

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170316/bcc0abce/attachment-0001.html>