<table><tr><td style="">kossebau created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5071" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Some people play Sudoku on the train, others play<br />
Gredelbuil (grep, remove, build), i.e. manually cleaning up<br />
includes and forward declarations which are not needed</p>

<p>Done by primitive grepping for Q/K* class names and</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">removing any includes whose class does not have instances by a quick look in implementations in the same file</li>
<li class="remarkup-list-item">using forward declarations instead of includes for classes whe possible, unless a template class (because the latter is quite verbose as forward declarations, the include nicer to read)</li>
<li class="remarkup-list-item">removing any forward declarations which are not used in the same file</li>
</ul>

<p>(one day a bot/script will steal my game and beat me, o tempores)</p>

<p>WRT effects on dependent code, at least kdevelop will need one or<br />
two adaptions due to changed include visibility. That is done as<br />
part of a similar clean-up patch, which will be either directly<br />
pushed or also passed through review, as you prefer.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>BRANCH</strong><div><div>includeSpringCleaning</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5071" rel="noreferrer">https://phabricator.kde.org/D5071</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>debugger/breakpoint/breakpointmodel.cpp<br />
debugger/breakpoint/breakpointwidget.cpp<br />
debugger/breakpoint/breakpointwidget.h<br />
debugger/framestack/framestackmodel.h<br />
debugger/framestack/framestackwidget.cpp<br />
debugger/interfaces/ibreakpointcontroller.h<br />
debugger/interfaces/idebugsession.cpp<br />
debugger/interfaces/idebugsession.h<br />
debugger/interfaces/ivariablecontroller.h<br />
debugger/util/pathmappings.cpp<br />
debugger/util/treeitem.cpp<br />
debugger/util/treeitem.h<br />
debugger/util/treemodel.cpp<br />
debugger/variable/variablecollection.cpp<br />
debugger/variable/variablecollection.h<br />
debugger/variable/variablesortmodel.h<br />
debugger/variable/variabletooltip.cpp<br />
debugger/variable/variabletooltip.h<br />
debugger/variable/variablewidget.cpp<br />
debugger/variable/variablewidget.h<br />
documentation/documentationview.cpp<br />
documentation/documentationview.h<br />
interfaces/configpage.cpp<br />
interfaces/configpage.h<br />
interfaces/context.cpp<br />
interfaces/context.h<br />
interfaces/contextmenuextension.h<br />
interfaces/iassistant.cpp<br />
interfaces/iassistant.h<br />
interfaces/ibuddydocumentfinder.h<br />
interfaces/icompletionsettings.cpp<br />
interfaces/icore.h<br />
interfaces/idocumentation.cpp<br />
interfaces/idocumentationprovider.h<br />
interfaces/idocumentationproviderprovider.h<br />
interfaces/ipartcontroller.cpp<br />
interfaces/ipartcontroller.h<br />
interfaces/iplugin.h<br />
interfaces/iplugincontroller.h<br />
interfaces/iproblem.h<br />
interfaces/iproject.cpp<br />
interfaces/iproject.h<br />
interfaces/iprojectcontroller.h<br />
interfaces/iprojectprovider.h<br />
interfaces/iruncontroller.h<br />
interfaces/isourceformatter.cpp<br />
interfaces/isourceformatter.h<br />
interfaces/isourceformattercontroller.h<br />
interfaces/itestcontroller.h<br />
interfaces/itestsuite.h<br />
interfaces/iuicontroller.h<br />
interfaces/launchconfigurationtype.h<br />
language/assistant/staticassistantsmanager.cpp<br />
language/assistant/staticassistantsmanager.h<br />
language/backgroundparser/backgroundparser.h<br />
language/backgroundparser/documentchangetracker.cpp<br />
language/backgroundparser/parsejob.cpp<br />
language/backgroundparser/tests/testlanguagesupport.cpp<br />
language/checks/controlflowgraph.h<br />
language/classmodel/classmodelnode.h<br />
language/codecompletion/codecompletion.h<br />
language/codecompletion/codecompletionmodel.cpp<br />
language/codecompletion/codecompletionmodel.h<br />
language/codecompletion/codecompletiontesthelper.h<br />
language/codecompletion/codecompletionworker.h<br />
language/codegen/archivetemplateloader.cpp<br />
language/codegen/codegenerator.cpp<br />
language/codegen/templateengine.cpp<br />
language/codegen/tests/test_templateclassgenerator.h<br />
language/codegen/tests/test_templaterenderer.h<br />
language/codegen/tests/test_templatesmodel.cpp<br />
language/codegen/tests/test_templatesmodel.h<br />
language/duchain/abstractfunctiondeclaration.h<br />
language/duchain/appendedlist.h<br />
language/duchain/builders/abstractcontextbuilder.h<br />
language/duchain/codemodel.cpp<br />
language/duchain/declarationid.h<br />
language/duchain/definitions.cpp<br />
language/duchain/duchain.cpp<br />
language/duchain/ducontext.cpp<br />
language/duchain/dumpdotgraph.h<br />
language/duchain/identifier.h<br />
language/duchain/importers.cpp<br />
language/duchain/navigation/abstractincludenavigationcontext.cpp<br />
language/duchain/navigation/abstractnavigationcontext.cpp<br />
language/duchain/navigation/abstractnavigationwidget.cpp<br />
language/duchain/navigation/abstractnavigationwidget.h<br />
language/duchain/navigation/problemnavigationcontext.cpp<br />
language/duchain/navigation/useswidget.h<br />
language/duchain/parsingenvironment.h<br />
language/duchain/persistentsymboltable.cpp<br />
language/duchain/tests/bench_hashes.cpp<br />
language/duchain/tests/test_duchainshutdown.cpp<br />
language/duchain/topducontext.cpp<br />
language/duchain/topducontextdynamicdata.cpp<br />
language/duchain/topducontextdynamicdata.h<br />
language/duchain/types/abstracttype.h<br />
language/duchain/types/typerepository.cpp<br />
language/duchain/types/typesystem.h<br />
language/duchain/uses.cpp<br />
language/highlighting/codehighlighting.h<br />
language/interfaces/abbreviations.cpp<br />
language/interfaces/abbreviations.h<br />
language/interfaces/quickopenfilter.h<br />
language/util/navigationtooltip.cpp<br />
outputview/outputexecutejob.h<br />
outputview/outputfilteringstrategies.h<br />
outputview/outputjob.h<br />
outputview/outputmodel.cpp<br />
outputview/tests/test_filteringstrategy.h<br />
outputview/tests/testlinebuilderfunctions.h<br />
plugins/appwizard/appwizarddialog.cpp<br />
plugins/appwizard/projectselectionpage.cpp<br />
plugins/appwizard/projecttemplatesmodel.h<br />
plugins/appwizard/projectvcspage.h<br />
plugins/bazaar/bazaarplugin.cpp<br />
plugins/bazaar/bzrannotatejob.h<br />
plugins/bazaar/tests/test_bazaar.cpp<br />
plugins/bazaar/tests/test_bazaar.h<br />
plugins/codeutils/codeutilsplugin.cpp<br />
plugins/contextbrowser/browsemanager.h<br />
plugins/contextbrowser/contextbrowserview.cpp<br />
plugins/contextbrowser/contextbrowserview.h<br />
plugins/documentswitcher/documentswitcherplugin.h<br />
plugins/documentswitcher/documentswitchertreeview.cpp<br />
plugins/documentview/kdevdocumentviewdelegate.cpp<br />
plugins/documentview/kdevdocumentviewdelegate.h<br />
plugins/documentview/kdevdocumentviewplugin.cpp<br />
plugins/execute/executeplugin.h<br />
plugins/execute/nativeappjob.h<br />
plugins/executescript/executescriptplugin.h<br />
plugins/executescript/iexecutescriptplugin.h<br />
plugins/externalscript/externalscriptitem.h<br />
plugins/externalscript/externalscriptplugin.cpp<br />
plugins/externalscript/externalscriptplugin.h<br />
plugins/filemanager/filemanager.cpp<br />
plugins/filemanager/kdevfilemanagerplugin.cpp<br />
plugins/filemanager/kdevfilemanagerplugin.h<br />
plugins/filetemplates/templateoptionspage.cpp<br />
plugins/filetemplates/templatepreview.cpp<br />
plugins/filetemplates/templatepreviewtoolview.cpp<br />
plugins/filetemplates/templateselectionpage.h<br />
plugins/filetemplates/testcasespage.cpp<br />
plugins/filetemplates/tests/data/testgenerationtest/templates/test_qtestlib/class.h<br />
plugins/filetemplates/tests/expected/testname.h<br />
plugins/filetemplates/tests/test_generationtest.cpp<br />
plugins/filetemplates/tests/test_generationtest.h<br />
plugins/genericprojectmanager/genericmanager.cpp<br />
plugins/git/gitplugin.cpp<br />
plugins/git/gitplugin.h<br />
plugins/git/tests/test_git.cpp<br />
plugins/git/tests/test_git.h<br />
plugins/grepview/grepdialog.h<br />
plugins/grepview/grepoutputmodel.cpp<br />
plugins/grepview/grepoutputview.cpp<br />
plugins/grepview/greputil.h<br />
plugins/openwith/openwithplugin.cpp<br />
plugins/outlineview/outlineviewplugin.cpp<br />
plugins/outlineview/outlinewidget.cpp<br />
plugins/outlineview/outlinewidget.h<br />
plugins/patchreview/localpatchsource.cpp<br />
plugins/patchreview/patchreview.h<br />
plugins/perforce/perforceplugin.cpp<br />
plugins/perforce/perforceplugin.h<br />
plugins/perforce/test/test_perforce.cpp<br />
plugins/problemreporter/problemreporterplugin.cpp<br />
plugins/problemreporter/problemsview.h<br />
plugins/problemreporter/problemtreeview.cpp<br />
plugins/problemreporter/tests/test_problemsview.cpp<br />
plugins/projectfilter/projectfilter.cpp<br />
plugins/projectfilter/projectfilter.h<br />
plugins/projectfilter/projectfilterconfigpage.cpp<br />
plugins/projectfilter/projectfilterprovider.cpp<br />
plugins/projectmanagerview/projectbuildsetwidget.cpp<br />
plugins/projectmanagerview/projectbuildsetwidget.h<br />
plugins/projectmanagerview/projectmanagerview.cpp<br />
plugins/projectmanagerview/projectmanagerview.h<br />
plugins/projectmanagerview/projectmanagerviewplugin.h<br />
plugins/projectmanagerview/projecttreeview.cpp<br />
plugins/projectmanagerview/projecttreeview.h<br />
plugins/quickopen/actionsquickopenprovider.cpp<br />
plugins/quickopen/documentationquickopenprovider.cpp<br />
plugins/quickopen/duchainitemquickopen.cpp<br />
plugins/quickopen/expandingtree/expandingdelegate.cpp<br />
plugins/quickopen/expandingtree/expandingdelegate.h<br />
plugins/quickopen/expandingtree/expandingtree.cpp<br />
plugins/quickopen/expandingtree/expandingwidgetmodel.cpp<br />
plugins/quickopen/expandingtree/expandingwidgetmodel.h<br />
plugins/quickopen/projectfilequickopen.h<br />
plugins/quickopen/quickopenmodel.h<br />
plugins/quickopen/quickopenplugin.cpp<br />
plugins/quickopen/quickopenwidget.cpp<br />
plugins/quickopen/quickopenwidget.h<br />
plugins/standardoutputview/standardoutputview.h<br />
plugins/standardoutputview/standardoutputviewmetadata.cpp<br />
plugins/standardoutputview/tests/test_standardoutputview.cpp<br />
plugins/standardoutputview/toolviewdata.h<br />
plugins/subversion/kdevsvnplugin.h<br />
plugins/subversion/svnaddjob.h<br />
plugins/subversion/svncatjob.h<br />
plugins/subversion/svncatjob_p.h<br />
plugins/subversion/svncheckoutmetadatawidget.cpp<br />
plugins/subversion/svnclient.cpp<br />
plugins/subversion/svnclient.h<br />
plugins/subversion/svncommitjob.cpp<br />
plugins/subversion/svncommitjob.h<br />
plugins/subversion/svncommitjob_p.h<br />
plugins/subversion/svncopyjob.h<br />
plugins/subversion/svndiffjob.cpp<br />
plugins/subversion/svndiffjob.h<br />
plugins/subversion/svndiffjob_p.h<br />
plugins/subversion/svninfojob.h<br />
plugins/subversion/svninternaljobbase.cpp<br />
plugins/subversion/svninternaljobbase.h<br />
plugins/subversion/svnjobbase.cpp<br />
plugins/subversion/svnjobbase.h<br />
plugins/subversion/svnmovejob.h<br />
plugins/subversion/svnremovejob.h<br />
plugins/subversion/svnrevertjob.h<br />
plugins/subversion/svnssldialog.cpp<br />
plugins/subversion/svnssldialog.h<br />
plugins/subversion/svnstatusjob.cpp<br />
plugins/subversion/svnstatusjob_p.h<br />
plugins/subversion/svnupdatejob.cpp<br />
plugins/subversion/svnupdatejob.h<br />
plugins/subversion/tests/svnimport.cpp<br />
plugins/subversion/tests/svnrecursiveadd.cpp<br />
plugins/switchtobuddy/switchtobuddyplugin.cpp<br />
plugins/testview/testview.cpp<br />
plugins/testview/testviewplugin.cpp<br />
plugins/vcschangesview/vcschangesviewplugin.h<br />
plugins/welcomepage/uihelper.cpp<br />
plugins/welcomepage/uihelper.h<br />
plugins/welcomepage/welcomepageview.cpp<br />
project/abstractfilemanagerplugin.cpp<br />
project/builderjob.h<br />
project/helper.cpp<br />
project/interfaces/iprojectbuilder.h<br />
project/interfaces/iprojectfilemanager.h<br />
project/interfaces/iprojectfilter.h<br />
project/projectbuildsetmodel.h<br />
project/projectconfigpage.h<br />
project/projectmodel.h<br />
project/projectproxymodel.h<br />
project/tests/projectmodelperformancetest.cpp<br />
project/tests/test_projectmodel.cpp<br />
serialization/abstractitemrepository.h<br />
serialization/itemrepositoryregistry.h<br />
serialization/tests/test_itemrepository.cpp<br />
serialization/tests/test_itemrepositoryregistry_automatic.cpp<br />
(123 more files...)</div></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>