D4981: patchreview : allow choice of the number of context lines

[René J.V. Bertin]

rjvbb updated this revision to Diff 12382.
rjvbb added a comment.


  This revision removes the spinbox from the UI and replaces it with a limited-choice contextmenu hidden under the Update button itself. A tooltip informs the user of the feature's existence.
  
  I haven't yet removed the spinbox hooks, and I'll look into triggering the contextmenu via a tap-and-hold too (just for giggles but could be nice for us Mac users who generally don't have a physical right mouse button).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4981?vs=12375&id=12382

REVISION DETAIL
  https://phabricator.kde.org/D4981

AFFECTED FILES
  plugins/bazaar/bazaarplugin.cpp
  plugins/cvs/cvsplugin.cpp
  plugins/cvs/cvsplugin.h
  plugins/git/gitplugin.cpp
  plugins/patchreview/patchreview.cpp
  plugins/patchreview/patchreview.h
  plugins/patchreview/patchreview.ui
  plugins/patchreview/patchreviewtoolview.cpp
  plugins/patchreview/patchreviewtoolview.h
  plugins/perforce/perforceplugin.cpp
  plugins/subversion/kdevsvnplugin.cpp
  vcs/interfaces/ibasicversioncontrol.h
  vcs/interfaces/ipatchsource.h
  vcs/widgets/vcsdiffpatchsources.cpp
  vcs/widgets/vcsdiffpatchsources.h

To: rjvbb, kfunk, #kdevelop
Cc: kfunk, apol, kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170311/ff633f9e/attachment.html>