D6308: Fix crashy dialogs (found by krazy and by hand)

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jun 28 08:58:06 UTC 2017


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dialogwrapper.h:55
> +template<typename DialogType>
> +class KDEVPLATFORMUTIL_EXPORT DialogWrapper {
> +    public:

I would rename it to `ScopedDialog`.

REPOSITORY
  R33 KDevPlatform

BRANCH
  crashy

REVISION DETAIL
  https://phabricator.kde.org/D6308

To: croick, #kdevelop, apol
Cc: apol, anthonyfieroni, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170628/6084e24d/attachment.html>


More information about the KDevelop-devel mailing list