D6308: Fix crashy dialogs (found by krazy and by hand)

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dialogwrapper.h:55
> +template<typename DialogType>
> +class KDEVPLATFORMUTIL_EXPORT DialogWrapper {
> +    public:

Exporting template class makes no sense to linker. You can export only complete types, i.e.

  #ifdef LIB // your library that export symbols
  #    define TEMPLATE(x)    template class x
  #else // library clients
  #    define TEMPLATE(x)    extern template class x
  #endif
  TEMPLATE(DialogWrapper<Type>); // somewhere in shared header file

This is not needed here, even this may vary between compilers (mostly MS compilers violate it).

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6308

To: croick, #kdevelop
Cc: anthonyfieroni, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170628/c7410fa2/attachment.html>