D6342: Add more typehints to arguments in PHP

[Heinz Wiesinger]

pprkut accepted this revision.
pprkut added a comment.
This revision is now accepted and ready to land.


  The changes look good, although I think it would be preferable to have the basic types in a separate commit from the more complicated ones like `iterable`, `self`, `object`, etc.
  
  Regarding the tokens, I'm afraid that's the way it is right now. There's currently no way to support more than one PHP version and traditionally we opted for the newest one.
  My next goal was context sensitive lexer support which should take care of the problem with using the tokens as identifiers, so I wouldn't worry too much about that.
  
  IMHO, `self` should still work as a token. We could take a look at the errors you're getting in a separate WIP diff. You could take some hints from the grammar definition in the PHP7 source and see how they did it for comparison.
  
  Regarding `callable`, I'm not sure what you mean.

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D6342

To: mtijink, #kdevelop, pprkut
Cc: apol, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170627/8f93fb32/attachment.html>