D6316: Add codecompletion from embedded structs

[Sven Brauch]

brauch added a comment.


  > After some lookup I found that there are 2 declarations added somehow with same qualifiedIdentifier.
  >  Also, looks like it my added test visitTypeSpec is somehow called twice thus in first call declaration is present once and it doesn't  contain internal context and in second call there is 2 declarations where first one still doesn't have internal context and second have one.
  
  I will have to look closer later, but typically the builders run twice per pass, and in the second pass the declaration created by the first pass should be *re-used*, i.e. openDeclaration() figures out which declaration was created by the first pass and re-uses that. It uses the scope identifier and the range to do that lookup. It might be that this fails. It definitely fails in some cases -- that is why your completion items sometimes disappear while the popup is visible.

REPOSITORY
  R59 KDevelop Go

REVISION DETAIL
  https://phabricator.kde.org/D6316

To: ematirov, apol, brauch
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170626/c78bb9a5/attachment.html>