D6308: Fix crashy dialogs (found by krazy and by hand)

[Anthony Fieroni]

anthonyfieroni added a comment.


  In https://phabricator.kde.org/D6308#119094, @croick wrote:
  
  > Good point! I used that inside the functions now, since it only occurs twice.
  >
  > For the rest, I hopefully excluded all parentless dialogs from the patch such that these remain two special cases.
  
  
  I mean when it can be useful when you have more that one deletion i.e.
  
    type *dialog = new dialog;
    if (dialog->exec()) {
        delete dialog;
        return;
    }
    .
    .
    .
    delete dialog;
  
  It can be done without 2 lines of deletes if you use wrapper
  
    wrapper *dialog = new dialog;
    if (dialog->exec()) {
        return;
    }

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6308

To: croick, #kdevelop
Cc: anthonyfieroni, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170624/f0450fa7/attachment.html>