D6308: Fix crashy dialogs (found by krazy and by hand)

Christoph Roick noreply at phabricator.kde.org
Fri Jun 23 21:52:52 UTC 2017


croick added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in projectselectionpage.cpp:335
> Check should be done on every exec afterwards dialog is used, cause potentially it can be deleted

Do you mean like this? DownloadDialog does not delete itself, so I'm wondering what could go wrong, since changedEntries will just be empty.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6308

To: croick, #kdevelop
Cc: anthonyfieroni, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170623/e05fb354/attachment.html>


More information about the KDevelop-devel mailing list