D6308: Fix crashy dialogs (found by krazy and by hand)

[Christoph Roick]

croick created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  - use QPointer instead of a stack variable when QDialogs are created with non-null parents
  - some false positives are marked
  - some dialogs have the main window as parent, they may still cause a crash, when the program is killed

TEST PLAN
  Before:
  
  - open "About KDevelop Platform" dialog
  - "killall kdevelop" -> kdevelop closes (as intended), but with crash
  
  After:
  
  - open same dialog
  - "killall kdevelop" -> kdevelop silently quits

REPOSITORY
  R33 KDevPlatform

BRANCH
  crashy

REVISION DETAIL
  https://phabricator.kde.org/D6308

AFFECTED FILES
  language/codegen/basicrefactoring.cpp
  plugins/appwizard/appwizardplugin.cpp
  plugins/appwizard/projectselectionpage.cpp
  plugins/externalscript/externalscriptview.cpp
  plugins/filetemplates/templateselectionpage.cpp
  plugins/git/gitplugin.cpp
  plugins/subversion/kdevsvnplugin.cpp
  plugins/subversion/svnjobbase.cpp
  project/projectitemlineedit.cpp
  shell/documentcontroller.cpp
  shell/environmentconfigurebutton.cpp
  shell/loadedpluginsdialog.cpp
  shell/mainwindow_actions.cpp
  shell/projectcontroller.cpp
  shell/sessioncontroller.cpp
  shell/settings/environmentwidget.cpp
  shell/settings/sourceformattersettings.cpp
  shell/settings/templatepage.cpp
  shell/uicontroller.cpp
  vcs/dvcs/dvcsplugin.cpp
  vcs/vcspluginhelper.cpp

To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170620/d954a21a/attachment.html>