<table><tr><td style="">croick created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6308" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">use QPointer instead of a stack variable when QDialogs are created with non-null parents</li>
<li class="remarkup-list-item">some false positives are marked</li>
<li class="remarkup-list-item">some dialogs have the main window as parent, they may still cause a crash, when the program is killed</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Before:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">open "About KDevelop Platform" dialog</li>
<li class="remarkup-list-item">"killall kdevelop" -> kdevelop closes (as intended), but with crash</li>
</ul>

<p>After:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">open same dialog</li>
<li class="remarkup-list-item">"killall kdevelop" -> kdevelop silently quits</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>BRANCH</strong><div><div>crashy</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6308" rel="noreferrer">https://phabricator.kde.org/D6308</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>language/codegen/basicrefactoring.cpp<br />
plugins/appwizard/appwizardplugin.cpp<br />
plugins/appwizard/projectselectionpage.cpp<br />
plugins/externalscript/externalscriptview.cpp<br />
plugins/filetemplates/templateselectionpage.cpp<br />
plugins/git/gitplugin.cpp<br />
plugins/subversion/kdevsvnplugin.cpp<br />
plugins/subversion/svnjobbase.cpp<br />
project/projectitemlineedit.cpp<br />
shell/documentcontroller.cpp<br />
shell/environmentconfigurebutton.cpp<br />
shell/loadedpluginsdialog.cpp<br />
shell/mainwindow_actions.cpp<br />
shell/projectcontroller.cpp<br />
shell/sessioncontroller.cpp<br />
shell/settings/environmentwidget.cpp<br />
shell/settings/sourceformattersettings.cpp<br />
shell/settings/templatepage.cpp<br />
shell/uicontroller.cpp<br />
vcs/dvcs/dvcsplugin.cpp<br />
vcs/vcspluginhelper.cpp</div></div></div><br /><div><strong>To: </strong>croick, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>