D5707: Normalize line endings when creating ParseJob from background file.

[Kevin Funk]

kfunk added a comment.


  Rest LGTM

INLINE COMMENTS

> kdevstringhandler.cpp:239
> +            continue;
> +        } else if (i + 1 < s && text[i + 1] == '\n') {
> +            text.remove(i, 1);

Style: No need for `else if` after `continue`.

Do:

  if (expr1) {
      continue;
  }
  
  if (expr2) {
  ...

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5707

To: flherne, brauch, #kdevelop, mwolff
Cc: kfunk, nalvarez, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170725/83571082/attachment.html>