<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5707" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5707#inline-28298" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kdevstringhandler.cpp:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">continue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">i</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span> <span style="color: #aa2211"><</span> <span class="n">s</span> <span style="color: #aa2211">&&</span> <span class="n">text</span><span class="p">[</span><span class="n">i</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #766510">'\n'</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">text</span><span class="p">.</span><span class="n">remove</span><span class="p">(</span><span class="n">i</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Style: No need for <tt style="background: #ebebeb; font-size: 13px;">else if</tt> after <tt style="background: #ebebeb; font-size: 13px;">continue</tt>.</p>

<p style="padding: 0; margin: 8px;">Do:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (expr1) {
    continue;
}

if (expr2) {
...</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5707" rel="noreferrer">https://phabricator.kde.org/D5707</a></div></div><br /><div><strong>To: </strong>flherne, brauch, KDevelop, mwolff<br /><strong>Cc: </strong>kfunk, nalvarez, mwolff, kdevelop-devel<br /></div>