D6593: Remove messages of already running CTests for UnitTests

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jul 10 10:07:04 UTC 2017


apol added a comment.


  Other than that, LGTM. I'm not sure why you need to go through the job list again, but it's not a big penalty so if that's what makes it stable, let's go for it.

INLINE COMMENTS

> nativeappjob.cpp:51
> +        if (cfgGroup.readEntry(ExecutePlugin::isExecutableEntry, false)) {
> +            m_name = cfgGroup.readEntry(ExecutePlugin::executableEntry, cfg->name()).split('/').last();
> +        }

Either do `splitRef` or `section`.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6593

To: croick, #kdevelop
Cc: apol, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170710/9dad4319/attachment.html>


More information about the KDevelop-devel mailing list