[Differential] [Updated] D4250: Add :vsplit and :split support in kdevelop

[Laurent George]

head7 marked an inline comment as done.
head7 added a comment.


  In https://phabricator.kde.org/D4250#79740, @mwolff wrote:
  
  > That sounds... odd - the rest of the MainWindow API we overload already works, or doesn't it? I.e. what we have in ktexteditorpluginintegration.h's MainWindow only ever gets called when it is the parent() object of the MainWindow in ktexteditor.
  >
  > If that is not the case, then something is really wrong. We have a test case for this in shell/tests/test_ktexteditorpluginintegration.cpp - is that failing for you?
  
  
  No the test succeed on my computer:
  
  - Start testing of TestKTextEditorPluginIntegration *********
  
  Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 6.2.0 20161027)
  QWARN  : TestKTextEditorPluginIntegration::initTestCase() cannot find .rc file "test_ktexteditorpluginintegrationui.rc" for component "test_ktexteditorpluginintegration"
  PASS   : TestKTextEditorPluginIntegration::initTestCase()
  PASS   : TestKTextEditorPluginIntegration::testApplication()
  PASS   : TestKTextEditorPluginIntegration::testMainWindow()
  PASS   : TestKTextEditorPluginIntegration::testPlugin()
  PASS   : TestKTextEditorPluginIntegration::testPluginUnload()
  PASS   : TestKTextEditorPluginIntegration::cleanupTestCase()
  Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 421ms
  
  - Finished testing of TestKTextEditorPluginIntegration *********
  
  But there is no tests checking toKteView parent ?

REVISION DETAIL
  https://phabricator.kde.org/D4250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: head7, brauch
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170130/a24dc1f5/attachment.html>