[Differential] [Commented On] D4287: File templates assistant: focus first edit field on switch to new page

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Jan 29 22:01:10 UTC 2017


kossebau added inline comments.

INLINE COMMENTS

> mwolff wrote in templateclassassistant.cpp:519
> 1. The pages are under our control, right? so it's not an optional feature? So adding an interface for that would make sense to me.
> 
> 2. I have no clue about focus proxies
> 
> but, in general, isn't there a way to set the widget focus from designer and couldn't that be used instead of all this manual code?

Re 1. Updated patch for a version with a custom interface. Might later perhaps make this a global kdevplatform interface and use it in other assistants as well, but for now kept the interface class in the plugin.

Re in general. Not that I am aware of. At least not when it comes to focus setting on switching between widgets, and more, if for switching between pages other widgets are used, here the buttons, which also can have keyboard focus.

KPageDialog/KAssistantDialog itself does not do any focus handling, leaves that all to implementors, for good and for bad.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4287

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop
Cc: mwolff, arrowdodger, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170129/6d4f9168/attachment-0001.html>


More information about the KDevelop-devel mailing list