[Differential] [Request, 426 lines] D4182: Remove decorator declarations

[Francis Herne]

flherne created this revision.
flherne added a reviewer: brauch.
flherne set the repository for this revision to R53 KDevelop: Python Support.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  These seem to have been used for the builtin documentation before the current docstring solution. Currently we do nothing with decorators except a few hardcoded ones, and this declaration system is needlessly complicated.
  
  Also fixes a bug - decorator declarations were never *removed* from a function, so removing a decorator would have no effect until renaming or moving the function.
  
  Regression - codecompletion now adds brackets to property accesses.
  Could add a temporary 'isProperty' status to functions, but I hope to implement real property support soonish.

TEST PLAN
  Tested that the effects of decorators now go away when they're edited out.
  
  Removes the decorator duchaintests, because they don't make sense without decorator declarations. The visible behaviour we actually implement (static/classmethods) is already included in several other tests.
  
  Adds XFAIL to one completion test.
  
  No other regressions.

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D4182

AFFECTED FILES
  codecompletion/items/functiondeclaration.cpp
  codecompletion/tests/pycompletiontest.cpp
  duchain/CMakeLists.txt
  duchain/declarationbuilder.cpp
  duchain/declarations/classdeclaration.cpp
  duchain/declarations/classdeclaration.h
  duchain/declarations/decorator.h
  duchain/declarations/functiondeclaration.cpp
  duchain/declarations/functiondeclaration.h
  duchain/expressionvisitor.h
  duchain/helpers.h
  duchain/tests/pyduchaintest.cpp
  duchain/tests/pyduchaintest.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170118/eb8c2da2/attachment.html>