<table><tr><td style="">flherne created this revision.<br />flherne added a reviewer: brauch.<br />flherne set the repository for this revision to R53 KDevelop: Python Support.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4182" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>These seem to have been used for the builtin documentation before the current docstring solution. Currently we do nothing with decorators except a few hardcoded ones, and this declaration system is needlessly complicated.</p>

<p>Also fixes a bug - decorator declarations were never *removed* from a function, so removing a decorator would have no effect until renaming or moving the function.</p>

<p>Regression - codecompletion now adds brackets to property accesses.<br />
Could add a temporary 'isProperty' status to functions, but I hope to implement real property support soonish.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested that the effects of decorators now go away when they're edited out.</p>

<p>Removes the decorator duchaintests, because they don't make sense without decorator declarations. The visible behaviour we actually implement (static/classmethods) is already included in several other tests.</p>

<p>Adds XFAIL to one completion test.</p>

<p>No other regressions.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4182" rel="noreferrer">https://phabricator.kde.org/D4182</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>codecompletion/items/functiondeclaration.cpp<br />
codecompletion/tests/pycompletiontest.cpp<br />
duchain/CMakeLists.txt<br />
duchain/declarationbuilder.cpp<br />
duchain/declarations/classdeclaration.cpp<br />
duchain/declarations/classdeclaration.h<br />
duchain/declarations/decorator.h<br />
duchain/declarations/functiondeclaration.cpp<br />
duchain/declarations/functiondeclaration.h<br />
duchain/expressionvisitor.h<br />
duchain/helpers.h<br />
duchain/tests/pyduchaintest.cpp<br />
duchain/tests/pyduchaintest.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>flherne, brauch<br /><strong>Cc: </strong>kdevelop-devel<br /></div>