[Differential] [Commented On] D3040: Allow scaling documentation view (BUG 285162)

[René J.V. Bertin]

rjvbb added a comment.


  In https://phabricator.kde.org/D3040#88391, @igorkushnir wrote:
  
  >
  
  
  
  
  > I've noticed an issue with my own shortcut implementation: the shortcut does not work in the Programmer Dvorak layout, because this layout requires pressing Shift to access digits. It also does not work with numpad 0. So I'd like to replace `event->modifiers() == Qt::ControlModifier` with `(event->modifiers() & Qt::ControlModifier)`. This will reset zoom level even if Ctrl+Shift+0 or Ctrl+Alt+0 is pressed. Please let me know if this is likely to cause conflicts with some global shortcuts. If it is, I could write even more specific code: `(event->modifiers() & Qt::ControlModifier) && !(event->modifiers() & ~(Qt::ControlModifier | Qt::ShiftModifier | Qt::KeypadModifier))`.
  
  Wouldn't it be possible to define an application-wide "Reset Zoom" (or "Zoom 100%") action with a shortcut that can be configured via the usual mechanism? That way you wouldn't have to jump through hoops in your code, and the action would (ultimately) become available in the other contexts where it would be most welcome.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: igorkushnir, mwolff, #kdevelop
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170221/a4d5425b/attachment.html>