[Differential] [Commented On] D3040: Allow scaling documentation view (BUG 285162)

Mon Feb 20 21:27:02 UTC 2017

rjvbb added inline comments.

INLINE COMMENTS

> mwolff wrote in standarddocumentationview.cpp:84
> Q_ASSERT(!d->m_zoomController)

Not my review, but FWIW, that's turning a function that only does something the 1st time into one that either crashes or else leaks ZoomController instances.

IMHO asserts like this should only be used for conditions that cannot be handled gracefully regardless of whether they should never happen.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: igorkushnir, mwolff, #kdevelop
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170220/c83f38f6/attachment-0001.html>