[Differential] [Requested Changes] D3040: Allow scaling documentation view (BUG 285162)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:7
>  # plugin versions listed in the .desktop files
> -set(KDEV_PLUGIN_VERSION 26)
> +set(KDEV_PLUGIN_VERSION 27)
>  # Increase this to reset incompatible item-repositories

still unrelated

> standarddocumentationview.cpp:25
>  #include "debug.h"
> +#include <util/zoomcontroller.h>
> +

add a newline before

> standarddocumentationview.cpp:44
> +    : QWebView(parent)
> +    , d{new StandardDocumentationViewPrivate()}
>  {

remove `()`

> standarddocumentationview.cpp:63
> +
> +StandardDocumentationView::~StandardDocumentationView()
> +{

default;
========

> standarddocumentationview.cpp:84
> +{
> +    if (Q_UNLIKELY(d->m_zoomController)) {
> +        qCWarning(DOCUMENTATION) << "Calling StandardDocumentationView::initZoom a second time has no effect.";

Q_ASSERT(!d->m_zoomController)

> standarddocumentationview.cpp:89
> +
> +    {
> +        const KConfigGroup outerGroup(KSharedConfig::openConfig(), QStringLiteral("Documentation View"));

remove this context

> standarddocumentationview.cpp:125
> +{
> +    if (d->m_zoomController && event->modifiers() == Qt::ControlModifier && event->key() == Qt::Key_0) {
> +        d->m_zoomController->resetZoom();

shouldn't this also be handled in the zoom controller?

  if (d->m_zoomController && d->m_zoomcontroller->handleKeyPressEvent(event)) {
      return;
  }

like the code below

> zoomcontroller.cpp:76
> +
> +ZoomController::ZoomController(const KConfigGroup& configGroup,
> +                               QObject* parent)

join next line

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: igorkushnir, mwolff, #kdevelop
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170220/2b518167/attachment-0001.html>