[Differential] [Requested Changes] D3040: Allow scaling documentation view (BUG 285162)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  I think the zoomcontroller is OK, we could probably use that code elsewhere

INLINE COMMENTS

> CMakeLists.txt:7
>  # plugin versions listed in the .desktop files
> -set(KDEV_PLUGIN_VERSION 26)
> +set(KDEV_PLUGIN_VERSION 27)
>  # Increase this to reset incompatible item-repositories

unrelated

> standarddocumentationview.cpp:39
>  StandardDocumentationView::StandardDocumentationView(DocumentationFindWidget* findWidget, QWidget* parent)
> -    : QWebView (parent)
> +    : QWebView(parent), d{new StandardDocumentationViewPrivate()}
>  {

put on its own line

  Foo::Foo()
      : Base()
      , m_asdf(...)
  {
      ...
  }

> zoomcontroller.cpp:23
> +#include "zoomcontroller.h"
> +#include "debug.h"
> +#include <KConfigGroup>

newline before

> zoomcontroller.cpp:24
> +#include "debug.h"
> +#include <KConfigGroup>
> +#include <KSharedConfig>

newline before

> zoomcontroller.cpp:26
> +#include <KSharedConfig>
> +#include <QPoint>
> +#include <QString>

newline before

> zoomcontroller.cpp:29
> +#include <QWheelEvent>
> +#include <cmath>
> +

newline before

i.e. we want to group includes

  #include "file.h"
  
  #include "..."
  
  #include <K...>
  #include <K...>
  
  #include <Q...>
  #include <Q...>
  
  #include <c...>

> zoomcontroller.h:44
> +    /**
> +     * @param configGroup KConfigGroup group name used to store configSubGroup
> +     * @param configSubGroup KConfigGroup nested group name used to store zoom factor

please pass KConfigGroup directly

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: igorkushnir, #kdevelop, mwolff
Cc: mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170218/c5814d8f/attachment.html>