[Differential] [Commented On] D4665: Fix project tree state not being saved

[Janek Bevendorff]

bevendorff added inline comments.

INLINE COMMENTS

> flherne wrote in projecttreeview.cpp:307
> Is this a good idea? It seems possibly confusing if the user doesn't remember which project was selected before.
> 
> If there's only one project, that should be assumed to be selected (cf. https://phabricator.kde.org/D4216).

This is needed to restore the tree state after opening the project (CMake) settings and reconfiguring the project.

> flherne wrote in projecttreeview.h:66
> Trivial style issue - the existing methods don't have spaces here.

Well, some have, some don't. But I'll change it. It's not my own code style anyway, always need to remind myself to add spaces.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4665

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bevendorff, mwolff, apol, kfunk
Cc: flherne, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170220/74a52848/attachment.html>