[Differential] [Commented On] D4657: Show all KTextEditor view bars in a central location

[Milian Wolff]

mwolff added a comment.


  Christoph, Dominik,: When comparing this implementation to the one in Kate:
  
  - why exactly is the `BarState` wrapper needed?
  - i.e. is `slotUpdateBottomViewBar` really needed, isn't that handled in KTextEditor? If it's needed, shouldn't this be in KTextEditor to call `{show,hide}ViewBar`?
  - Kate guards against `nullptr` view bars, is this really needed? Put differently - when would this ever occur? Shouldn't this be handled by KTextEditor to not call `addWidgetToViewBar`?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4657

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mwolff, #kdevelop, dhaumann, cullmann
Cc: kdevelop-devel, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170218/86344660/attachment.html>