<table><tr><td style="">mwolff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4657" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Christoph, Dominik,: When comparing this implementation to the one in Kate:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">why exactly is the <tt style="background: #ebebeb; font-size: 13px;">BarState</tt> wrapper needed?</li>
<li class="remarkup-list-item">i.e. is <tt style="background: #ebebeb; font-size: 13px;">slotUpdateBottomViewBar</tt> really needed, isn't that handled in KTextEditor? If it's needed, shouldn't this be in KTextEditor to call <tt style="background: #ebebeb; font-size: 13px;">{show,hide}ViewBar</tt>?</li>
<li class="remarkup-list-item">Kate guards against <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt> view bars, is this really needed? Put differently - when would this ever occur? Shouldn't this be handled by KTextEditor to not call <tt style="background: #ebebeb; font-size: 13px;">addWidgetToViewBar</tt>?</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4657" rel="noreferrer">https://phabricator.kde.org/D4657</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mwolff, KDevelop, dhaumann, cullmann<br /><strong>Cc: </strong>kdevelop-devel, KDevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>