[Differential] [Commented On] D4593: Standardize on "Executable" in UI & API, do not mix with "Binary"

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Feb 13 16:54:09 UTC 2017


kossebau added inline comments.

INLINE COMMENTS

> flherne wrote in midebugger.h:138
> Perhaps this should be debuggerExecutable_ for consistency within the class?

Good question. So far I was assuming that while touching lines the content would get transformed to latest coding style, even if then being inconsistent with the older neighbourhood. Will also poke devs on irc to get a +1/-1 on this.

> flherne wrote in testhelpers.h:36
> The QMake one has a //TODO

Well, spotted, +1 for closely reading all changes :) Would add a TODO to all such places on pushing.

REPOSITORY
  R32 KDevelop

BRANCH
  standardizeOnExecutable

REVISION DETAIL
  https://phabricator.kde.org/D4593

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, apol
Cc: flherne, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170213/df084a51/attachment.html>


More information about the KDevelop-devel mailing list