[Differential] [Changed Subscribers] D4593: Standardize on "Executable" in UI & API, do not mix with "Binary"

Francis Herne noreply at phabricator.kde.org
Mon Feb 13 11:17:57 UTC 2017


flherne added inline comments.

INLINE COMMENTS

> midebugger.h:138
>  protected:
> -    QString debuggerBinary_;
> +    QString m_debuggerExecutable;
>      KProcess* process_;

Perhaps this should be debuggerExecutable_ for consistency within the class?

> testhelpers.h:36
>  static QString currentBuildDirKey = "Build Directory Path";
> -static QString currentCMakeBinaryKey = "CMake Binary";
> +static QString currentCMakeExecutableKey = "CMake Binary";
>  static QString currentBuildTypeKey = "Build Type";

The QMake one has a //TODO

REPOSITORY
  R32 KDevelop

BRANCH
  standardizeOnExecutable

REVISION DETAIL
  https://phabricator.kde.org/D4593

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, apol
Cc: flherne, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170213/b961a62e/attachment.html>


More information about the KDevelop-devel mailing list