[Differential] [Accepted] D4423: Allow language plugin metadata JSON to declare support for >1 language

[Milian Wolff]

mwolff accepted this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm in principle

INLINE COMMENTS

> languagecontroller.cpp:227
> +            if (key == keys[1]) {
> +                qWarning() << "Plugin" << Core::self()->pluginController()->pluginInfo(supports[0]).name() << " has deprecated (since 5.1) metadata key 'X-KDevelop-Language', needs porting to 'X-KDevelop-Languages'";
> +            }

this needs to be emitted for every plugin that has this, no?

REPOSITORY
  R33 KDevPlatform

BRANCH
  renameLanguageMetaDataKey

REVISION DETAIL
  https://phabricator.kde.org/D4423

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170203/872fc7fa/attachment-0001.html>