[Differential] [Request, 41 lines] D4423: Allow language plugin metadata JSON to declare support for >1 language
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Fri Feb 3 01:06:26 UTC 2017
kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
A plugin implementing ILanguageSupport can specify the language supported
by the plugin JSON metadata key "X-KDevelop-Language", which is specified
to only take one string item.
The only known effective user of this metadata is the filetemplates plugin,
which takes the "Language" property of a to-be-applied template file to ask
the language controller for a matching language plugin, to get a proper
class helper object for the code generation.
KDevCLang currently has its "X-KDevelop-Language" metadata set to "C",
while it can support C, C++ & Objective-C. As a result the language
controller currently will not deliver KDevCLang to the filetemplate plugin
when asked for "C++", which then flaws the generation of C++ classes.
This patch introduces a new key "X-KDevelop-Languages" (for semantic correctness)
to fix this, and emits a temporary warning to help anyone to port their
language plugins as needed.
REPOSITORY
R33 KDevPlatform
BRANCH
renameLanguageMetaDataKey
REVISION DETAIL
https://phabricator.kde.org/D4423
AFFECTED FILES
interfaces/iplugin.h
interfaces/kdevelopplugin.desktop
language/codegen/sourcefiletemplate.h
plugins/patchreview/kdevpatchreview.json
shell/languagecontroller.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170203/f396e95c/attachment.html>
More information about the KDevelop-devel
mailing list