[Differential] [Accepted] D4122: Toolbar state was not being saved / restored

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.


  one minor code style nitpick, then it's ready to go
  
  thanks!

INLINE COMMENTS

> idealcontroller.cpp:122
> +      toolBar->setVisible(cg.readEntry(dockObjectName, true));
> +      connect(toolBar->toggleViewAction(), &QAction::toggled, this, [toolBar, dockObjectName](){
> +        KConfigGroup cg(KSharedConfig::openConfig(), "UiSettings/Docks/ToolbarEnabled");

please introduce a newline before the this and indent the lambda body

  connect(toolBar->toggleViewAction(), &QAction::toggled,
          this, [toolBar, dockObjectName]() {
              ...
          });

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4122

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, apol, antonanikin, kfunk, #kdevelop, mwolff
Cc: mwolff, antonanikin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170202/dd554a73/attachment.html>